Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process scraper: Use same scrape time for all data points coming from same process #1539

Conversation

james-bebbington
Copy link
Member

Link to tracking Issue: #1271

Updated all metrics related to the same process to use the same timestamp.

@james-bebbington james-bebbington changed the title Process scraper: Use same scrape time for all data points coming from… Process scraper: Use same scrape time for all data points coming from same process Aug 12, 2020
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #1539 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   91.42%   91.44%   +0.01%     
==========================================
  Files         248      248              
  Lines       17219    17220       +1     
==========================================
+ Hits        15743    15746       +3     
+ Misses       1064     1063       -1     
+ Partials      412      411       -1     
Impacted Files Coverage Δ
...internal/scraper/processscraper/process_scraper.go 98.34% <100.00%> (+0.01%) ⬆️
...al/scraper/processscraper/process_scraper_linux.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 87.50% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68440e...81485d8. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 063ef1b into open-telemetry:master Aug 13, 2020
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Signed-off-by: owentou <owentou@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants