Add a ‘Headers’ field in HTTPClientSettings #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyan0
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 91.44% 91.46% +0.01%
==========================================
Files 250 250
Lines 17307 17318 +11
==========================================
+ Hits 15827 15840 +13
+ Misses 1066 1065 -1
+ Partials 414 413 -1
Continue to review full report at Codecov.
|
This reverts commit 394f94f.
CunjunWang
approved these changes
Aug 14, 2020
EdZou
approved these changes
Aug 14, 2020
bogdandrutu
reviewed
Aug 14, 2020
|
@huyan0 I like that you cc-ed you :) |
bogdandrutu
approved these changes
Aug 14, 2020
fix TestAllHTTPClientSettings
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update license-check to ignore all vendor dirs * Remove vendor path exclude from license-check find
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a ‘Headers’ field in the HTTPClientSettings struct. When ToClient() is invoked, a client interceptor that adds headers to each request is created. It is used as the Transport field of the client returned by ToClient().
Link to tracking Issue: #1551
Testing: A unit test is added. It validates that headers in HTTPClientSettings is included in the request received by a HTTP server.
cc: @alolita @huyan0 @bogdandrutu