Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple exporters panic #1563

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fix multiple exporters panic #1563

merged 1 commit into from
Aug 17, 2020

Conversation

sumo-drosiek
Copy link
Member

Description:
Fixing a bug

While using more than one exporter the panic runtime exception occured,
because the array allocated for exporters was as twice as big as it should

Link to tracking Issue: N/A

Testing:

Using more than one exporter results with panic runtime error:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x510ca95]

goroutine 108 [running]:
go.opentelemetry.io/collector/processor.LogFanOutConnector.ConsumeLogs(0xc0002c0d40, 0x4, 0x4, 0x88ab900, 0xc0002c10c0, 0xc00082a000, 0xc000c19880, 0x2)
        .../processor/fanoutconnector.go:171 +0xb5

Documentation: N/A

Signed-off-by: Dominik Rosiek drosiek@sumologic.com

While using more than one exporter the panic runtime exception was fired
because the array allocated for exporters was as twice as big as it should

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 17, 2020

CLA Check
The committers are authorized under a signed CLA.

@project-bot project-bot bot added this to In progress in Collector Aug 17, 2020
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1563 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1563   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         250      250           
  Lines       17315    17315           
=======================================
  Hits        15839    15839           
  Misses       1062     1062           
  Partials      414      414           
Impacted Files Coverage Δ
service/builder/pipelines_builder.go 82.78% <0.00%> (ø)
translator/internaldata/resource_to_oc.go 81.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5c606...b4e2548. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Aug 17, 2020
@bogdandrutu bogdandrutu merged commit fa62be6 into open-telemetry:master Aug 17, 2020
Collector automation moved this from Reviewer approved to Done Aug 17, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…ncompatible in /tests (open-telemetry#1563)

* Bump github.com/docker/docker in /tests

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.8+incompatible to 20.10.16+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md)
- [Commits](moby/moby@v20.10.8...v20.10.16)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* go mod tidy

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jeffreyc-splunk <jeffreyc@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants