-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved common processor files and updated refs #1574
Moved common processor files and updated refs #1574
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
+ Coverage 91.91% 91.94% +0.02%
==========================================
Files 255 255
Lines 17546 17546
==========================================
+ Hits 16128 16132 +4
+ Misses 1013 1011 -2
+ Partials 405 403 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't follow the PKG convention. So probably filters, helpers are better names.
There is already a |
Changes made, but CI is failing. After investigating I don't believe the failures are related to any of the changes I have made. |
Please rebase, the CI for windows-msi was changed |
Also please update description :) |
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
1775f58
to
a523428
Compare
Thanks for the heads up @bogdandrutu. Tests passing. |
Description:
processor/processorhelper
folder to allow for external useThere are obviously a lot of ways to expose these files for external use. I chose the common go convention of using apkg
folder, but otherwise kept the folder structure. I am, however, fine putting these file wherever the maintainers would prefer. Please let me know if you'd like them in a different location.Per discussions below
processor/processorhelper
was agreed upon.Link to tracking Issue:
Fixes #1411
Testing:
n/a
Documentation:
n/a