Do not duplicate filesystem metrics for devices with many mount points. #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
bogdandrutu,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
dmitryax
force-pushed
the
ignore-multiple-mont-points-same-devide
branch
from
397662f
to
befb16d
Compare
james-bebbington
approved these changes
Aug 23, 2020
receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_scraper.go
Outdated
Show resolved
Hide resolved
dmitryax
force-pushed
the
ignore-multiple-mont-points-same-devide
branch
2 times, most recently
from
c786538
to
702787e
Compare
This commit fixes a bug that produces duplicate "filesystem" metric data points for linux devices that have more than one data point. For example:
```
{"device":"/dev/vda1","mountpoint":"/etc/resolv.conf","fstype":"ext4","opts":"rw,relatime"}
{"device":"/dev/vda1","mountpoint":"/etc/hostname","fstype":"ext4","opts":"rw,relatime"}
{"device":"/dev/vda1","mountpoint":"/etc/hosts","fstype":"ext4","opts":"rw,relatime"}
```
dmitryax
force-pushed
the
ignore-multiple-mont-points-same-devide
branch
from
702787e
to
3a73151
Compare
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 254 254
Lines 17527 17534 +7
=======================================
+ Hits 16111 16118 +7
Misses 1011 1011
Partials 405 405
Continue to review full report at Codecov.
|
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…ry#1617) Bumps [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a bug that produces duplicate "filesystem" metric data points for linux devices that have more than one data point. For example:
Resolves: #1615
Testing: Added a unit test.