Make pdata.LogsToOtlp and pdata.LogsFromOtlp impossible to call from outside this module #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais and
pjanotti
as code owners
tigrannajaryan
force-pushed
the
feature/tigran/hide-otlp-funcs
branch
2 times, most recently
from
195006d
to
a4694aa
Compare
bogdandrutu
reviewed
Sep 1, 2020
tigrannajaryan
force-pushed
the
feature/tigran/hide-otlp-funcs
branch
from
a4694aa
to
83361dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
+ Coverage 92.17% 92.31% +0.14%
==========================================
Files 259 259
Lines 18402 18211 -191
==========================================
- Hits 16962 16812 -150
+ Misses 1013 987 -26
+ Partials 427 412 -15
Continue to review full report at Codecov.
|
tigrannajaryan
pushed a commit
to tigrannajaryan/opentelemetry-collector
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
tigrannajaryan
added a commit
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in #1703
tigrannajaryan
force-pushed
the
feature/tigran/hide-otlp-funcs
branch
from
83361dc
to
f0a882f
Compare
tigrannajaryan
changed the title
tigrannajaryan
changed the title
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
tigrannajaryan
force-pushed
the
feature/tigran/hide-otlp-funcs
branch
from
f0a882f
to
a59da19
Compare
bogdandrutu
added a commit
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in #1703 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
tigrannajaryan
force-pushed
the
feature/tigran/hide-otlp-funcs
branch
from
a59da19
to
8848fdc
Compare
keitwb
approved these changes
Sep 2, 2020
|
@open-telemetry/collector-approvers I need a review/approval on this. |
…outside this module LogsToOtlp and LogsFromOtlp are intended to be used only by OTLP exporter (for which OTLP is the native data format) and fileexporter (for which we do want to output internal representation for debugging purposes). All other code is supposed to use public member functions of pdata.Logs struct. This changes makes it impossible to use LogsToOtlp and LogsFromOtlp outside this module by hiding them behind an intermediary struct that is declared in an internal package. This is necessary to prevent accidental use of LogsToOtlp and LogsFromOtlp and the OTLP data structs, which we prohibit to do since the OTLP data structs may change in the future.
tigrannajaryan
force-pushed
the
feature/tigran/hide-otlp-funcs
branch
from
8848fdc
to
07db553
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Add Valid method to KeyValue * Use KeyValue.Valid in attribute add on Span * Resource StringDetector errors for invalid attribute * Ignore invalid attr in NewWithAttributes The OpenTelemetry specification requires attributes conform to a standard evaluated and returned by attribute.KeyValue.Valid. To comply with the specification, Resources created from NewWithAttributes need to only contain valid attributes. This adds a check to ensure this and drops invalid attributes passed as arguments. * Add changes to changelog * Add nolint comment The attribute.Set is (possibly overly) optimized to avoid allocations. The returned value from the constructor is a value of a Set, not a pointer to the Set. A Set contains a lock value and pointer methods so passing the Set value raises the copylock go vet error. This copies the same nolint comment from the `NewSet` method this used to use. * Apply suggestions from code review Co-authored-by: Sam Xie <xsambundy@gmail.com> Co-authored-by: Sam Xie <xsambundy@gmail.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogsToOtlp and LogsFromOtlp are intended to be used only by OTLP exporter (for which
OTLP is the native data format) and fileexporter (for which we do want to output internal
representation for debugging purposes).
All other code is supposed to use public member functions of pdata.Logs struct.
This changes makes it impossible to use LogsToOtlp and LogsFromOtlp outside this module
by hiding them behind an intermediary struct that is declared in an internal package.
This is necessary to prevent accidental use of LogsToOtlp and LogsFromOtlp and the OTLP
data structs, which we prohibit to do since the OTLP data structs may change in the
future.