Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all exporters are started/shutdown #1943

Merged
merged 3 commits into from Oct 12, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1943 into master will increase coverage by 0.06%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   91.41%   91.48%   +0.06%     
==========================================
  Files         284      284              
  Lines       16788    16780       -8     
==========================================
+ Hits        15347    15351       +4     
+ Misses       1009     1000       -9     
+ Partials      432      429       -3     
Impacted Files Coverage Δ
service/builder/exporters_builder.go 81.73% <95.45%> (+5.54%) ⬆️
service/builder/pipelines_builder.go 88.42% <100.00%> (+5.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526f342...2f46ed2. Read the comment docs.

service/builder/exporters_builder.go Outdated Show resolved Hide resolved
service/builder/exporters_builder.go Outdated Show resolved Hide resolved
Collector automation moved this from In progress to Reviewer approved Oct 12, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit d495cf4 into open-telemetry:master Oct 12, 2020
Collector automation moved this from Reviewer approved to Done Oct 12, 2020
@bogdandrutu bogdandrutu deleted the fixserviceexp branch October 12, 2020 21:34
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…/otlp (open-telemetry#1943)

* Bump go.opentelemetry.io/proto/otlp in /exporters/otlp

Bumps [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases)
- [Commits](open-telemetry/opentelemetry-proto-go@v0.8.0...v0.9.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

* Remove use of depreciated StringKeyValue

* Revert example/passthrough/go.sum

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: MrAlias <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants