Remove ability to configure collection interval per scraper #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne (batch) scrapers
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
reviewed
Oct 13, 2020
bogdandrutu
reviewed
Oct 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
+ Coverage 91.46% 91.48% +0.02%
==========================================
Files 284 284
Lines 16739 16748 +9
==========================================
+ Hits 15310 15322 +12
+ Misses 1000 998 -2
+ Partials 429 428 -1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Oct 13, 2020
james-bebbington
force-pushed
the
receiverhelper-collectioninterval
branch
3 times, most recently
from
8a9fcf5
to
03e5cd3
Compare
bogdandrutu
reviewed
Oct 13, 2020
james-bebbington
force-pushed
the
receiverhelper-collectioninterval
branch
from
2f8a4dd
to
de43cf7
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ability to configure collection interval per scraper and combine (batch) scrapers