Fix OTLP/HTTP receiver's path to be /v1/traces #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais and
pjanotti
as code owners
tigrannajaryan
changed the title
tigrannajaryan
force-pushed
the
feature/tigran/otlp_rcv_http_traces_path
branch
from
2b91d5e
to
f582410
Compare
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 280 280
Lines 16523 16526 +3
=======================================
+ Hits 15108 15111 +3
Misses 979 979
Partials 436 436
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Oct 19, 2020
internal/data/opentelemetry-proto-gen/collector/trace/v1/trace_service_gateway_aliases.go
Outdated
Show resolved
Hide resolved
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace. OTLP spec require the path to be /v1/traces. This change adds /v1/traces as a supported alias in the receiver to match what spec requires. We will keep both paths supported for a while and then will eventually retire /v1/trace. Note that the OTLP/HTTP exporter already correctly uses /v1/traces path. Fixes: open-telemetry#1968
tigrannajaryan
force-pushed
the
feature/tigran/otlp_rcv_http_traces_path
branch
from
f582410
to
33d0003
Compare
bogdandrutu
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTLP/HTTP receiver was incorrectly expecting traces on /v1/trace.
OTLP spec require the path to be /v1/traces. This change adds /v1/traces
as a supported alias in the receiver to match what spec requires.
We will keep both paths supported for a while and then will eventually
retire /v1/trace.
Note that the OTLP/HTTP exporter already correctly uses /v1/traces path.
Fixes: #1968