Make all KeyValue non-nullable

[bogdandrutu]

Good win in the amount of allocations, and some nice win for the latency. In the current benchmarks only one attribute per resource, one attribute per span, one attribute per link, and one attribute per event.

Before:

goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/consumer/pdata
BenchmarkTracesFromOtlp
BenchmarkTracesFromOtlp-16    	     686	   1759476 ns/op	  981565 B/op	   35113 allocs/op
PASS

After:

goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/collector/consumer/pdata
BenchmarkTracesFromOtlp
BenchmarkTracesFromOtlp-16    	     666	   1720189 ns/op	  940353 B/op	   29961 allocs/op
PASS

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[codecov]

Codecov Report

Merging #2017 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.02%     
==========================================
  Files         284      284              
  Lines       16883    16879       -4     
==========================================
- Hits        15479    15473       -6     
- Misses        971      972       +1     
- Partials      433      434       +1     

Impacted Files	Coverage Δ
consumer/pdata/generated_metrics.go	100.00% <ø> (ø)
internal/goldendataset/span_generator.go	98.86% <ø> (ø)
consumer/pdata/common.go	96.69% <100.00%> (-0.04%)	⬇️
internal/data/testdata/common.go	100.00% <100.00%> (ø)
internal/data/testdata/log.go	100.00% <100.00%> (ø)
internal/goldendataset/generator_commons.go	88.88% <100.00%> (ø)
translator/internaldata/resource_to_oc.go	89.04% <0.00%> (-2.74%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd853a...22e4362. Read the comment docs.

[tigrannajaryan]

Nice.