Environment variable NO_WINDOWS_SERVICE to force interactive mode on Windows #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 272 272
Lines 15279 15284 +5
=======================================
+ Hits 14062 14067 +5
Misses 837 837
Partials 380 380
Continue to review full report at Codecov.
|
tigrannajaryan
requested changes
Dec 8, 2020
| return runInteractive(params) | ||
| } else { | ||
| return runService(params) | ||
| } | ||
| } | ||
|
|
||
| func checkUseInteractiveMode() (bool, error) { | ||
| if value, present := os.LookupEnv("NO_WINDOWS_SERVICE"); present && value != "0" { |
There was a problem hiding this comment.
Add a comment to explain what this does.
Added a section to |
This was referenced Mar 22, 2021
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 24, 2021
…Windows (#2819) This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers. Main repo PR description: > Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service. > > This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired. > >Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows.
mateuszrzeszutek
pushed a commit
to mateuszrzeszutek/splunk-otel-collector
that referenced
this pull request
Apr 8, 2021
This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers. Main repo PR description: > Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service. > > This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired. > >Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows. We want to use splunk-otel-collector in our splunk-otel-java smoke-tests, and that includes Windows tests. This change is required to make Windows containers work.
mateuszrzeszutek
pushed a commit
to mateuszrzeszutek/splunk-otel-collector
that referenced
this pull request
Apr 8, 2021
This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers. Main repo PR description: > Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service. > > This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired. > >Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows. We want to use splunk-otel-collector in our splunk-otel-java smoke-tests, and that includes Windows tests. This change is required to make Windows containers work.
rmfitzpatrick
pushed a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
Apr 8, 2021
…254) This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers. Main repo PR description: > Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service. > > This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired. > >Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows. We want to use splunk-otel-collector in our splunk-otel-java smoke-tests, and that includes Windows tests. This change is required to make Windows containers work.
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…Windows (#2819) This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers. Main repo PR description: > Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service. > > This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired. > >Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…-telemetry#2272) Before, the WatchForChanges was not called, now we pass the same WatcherFunc down to the ConfigSources. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service.
This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired.
Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows.