Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/fluentforward] Fix string conversions #2314

Merged
merged 2 commits into from Dec 21, 2020
Merged

[receiver/fluentforward] Fix string conversions #2314

merged 2 commits into from Dec 21, 2020

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Dec 21, 2020

  • Sometimes strings are received as []uint8
  • fluentd uses "message", fluent-bit uses "log" for the log message

@jrcamp
[receiver/fluentforward] Fix string conversions
01939b6 
- Sometimes strings are received as []uint8
- fluentd uses "message", fluent-bit uses "log" for the log message
@jrcamp jrcamp requested a review from keitwb December 21, 2020 17:48
@jrcamp jrcamp requested a review from a team as a code owner December 21, 2020 17:48
@project-bot project-bot bot added this to In progress in Collector Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020 •
edited

Codecov Report

Merging #2314 (ddc313d) into master (6196bd8) will decrease coverage by 0.03%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
- Coverage   92.04%   92.00%   -0.04%     
==========================================
  Files         272      272              
  Lines       15345    15341       -4     
==========================================
- Hits        14124    14115       -9     
- Misses        840      845       +5     
  Partials      381      381
Impacted Files Coverage Δ
receiver/fluentforwardreceiver/conversion.go 86.47% <58.33%> (-1.92%) ⬇️
internal/data/traceid.go 84.61% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6196bd8...ddc313d. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Dec 21, 2020
@bogdandrutu
Copy link
Member

Please fix the lint issues.

@bogdandrutu bogdandrutu merged commit d75a2f9 into open-telemetry:master Dec 21, 2020
Collector automation moved this from Reviewer approved to Done Dec 21, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
@atoulme
Add ppc64le manifest to latest manifest (open-telemetry#2314)
e8c50a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@keitwb keitwb Awaiting requested review from keitwb

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Collector
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrcamp @bogdandrutu