Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostmetricsreceiver: (network/paging/process) Refactor to use metrics metadata #2421

Merged
merged 5 commits into from Feb 8, 2021

Conversation

asuresh4
Copy link
Member

@asuresh4 asuresh4 commented Jan 29, 2021

Depends on #2406

Refactor network, paging, process and processes scrapers to use metrics metadata utility.

@project-bot project-bot bot added this to In progress in Collector Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #2421 (69d7a95) into main (c5f2b25) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
- Coverage   91.88%   91.80%   -0.08%     
==========================================
  Files         268      264       -4     
  Lines       15213    15073     -140     
==========================================
- Hits        13978    13838     -140     
  Misses        857      857              
  Partials      378      378              
Impacted Files Coverage Δ
...internal/scraper/networkscraper/network_scraper.go 97.91% <100.00%> (ø)
...nal/scraper/pagingscraper/paging_scraper_others.go 100.00% <100.00%> (ø)
...craper/processesscraper/processes_scraper_linux.go 100.00% <100.00%> (ø)
...scraper/processesscraper/processes_scraper_unix.go 100.00% <100.00%> (ø)
...internal/scraper/processscraper/process_scraper.go 98.13% <100.00%> (ø)
...al/scraper/processscraper/process_scraper_linux.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f2b25...69d7a95. Read the comment docs.

@asuresh4 asuresh4 changed the title hostmetricsreceiver: (network/paging) Refactor to use metrics metadata hostmetricsreceiver: (network/paging/process) Refactor to use metrics metadata Jan 29, 2021
@asuresh4 asuresh4 marked this pull request as ready for review January 29, 2021 19:02
@asuresh4 asuresh4 requested a review from a team as a code owner January 29, 2021 19:02
Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally only tests would use New()

@jrcamp jrcamp self-assigned this Feb 1, 2021
Collector automation moved this from In progress to Reviewer approved Feb 1, 2021
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Refactored while keeping current emitted metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants