-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
receiver/prometheus: add metricGroup.toSummaryPoint pdata conversion #3668
receiver/prometheus: add metricGroup.toSummaryPoint pdata conversion #3668
Conversation
Another one, kindly cc-ing @bogdandrutu @Aneurysm9 @rakyll @alolita @tigrannajaryan @anuraaga |
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
@Aneurysm9 @dashpole @rakyll please review - ty! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toSummaryPoint looks good.
@dashpole indeed the Summary looks good but depends on a PR with some comments :) |
Yes. This is not ready to merge. |
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
8444434
to
a601910
Compare
Please rebase |
Implements metricGroupPdata toSummaryPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3667 Updates PR open-telemetry#3427
a601910
to
cb9bd45
Compare
Rebase done, thanks @bogdandrutu! |
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue open-telemetry#3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR open-telemetry#3668 Updates PR open-telemetry#3427 Updates open-telemetry#3691
…on (#3674) Implements metricGroupPdata toNumberDataPoint and added unit tests as well as equivalence tests to ensure the migration will render the same results. While here, added TODOs for issue #3691 which found a bug in which cumulative types weren't using the actual duration start timestamp. Given that this current change is a translation of prior logic and has parity checks, making that bug fix would complicate the PR. Updates #3137 Depends on PR #3668 Updates PR #3427 Updates #3691
Implements metricGroupPdata toSummaryPoint and added unit tests
as well as equivalence tests to ensure the migration will render
the same results.
Updates #3137
Depends on PR #3667
Updates PR #3427