update NumberDataPoint to support DoubleVal and IntVal #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Jul 21, 2021
bogdandrutu
reviewed
Jul 21, 2021
bogdandrutu
reviewed
Jul 21, 2021
codeboten
force-pushed
the
codeboten/add-int-double-datapoint
branch
from
4274350
to
096ba31
Compare
bogdandrutu
reviewed
Jul 21, 2021
codeboten
force-pushed
the
codeboten/add-int-double-datapoint
branch
from
096ba31
to
a7fcf19
Compare
bogdandrutu
reviewed
Jul 21, 2021
codeboten
force-pushed
the
codeboten/add-int-double-datapoint
branch
from
a7fcf19
to
e7f06ca
Compare
bogdandrutu
reviewed
Jul 22, 2021
Comment on lines
2017
to
2018
| tv.SetDoubleVal(float64(17.13)) | ||
| tv.SetIntVal(int64(17)) |
There was a problem hiding this comment.
Should this be only one set?
There was a problem hiding this comment.
SetDoubleVal for now, added a TODO to remember to test with both int and double values in the future.
codeboten
force-pushed
the
codeboten/add-int-double-datapoint
branch
from
e7f06ca
to
e1058b2
Compare
bogdandrutu
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: updating NumberDataPoint to support both Double and Int, this is a stepping stone to remove IntDataPoint altogether.
Link to tracking Issue: Part of #3534