Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IntGauge/IntSum #3731

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Remove IntGauge/IntSum #3731

merged 2 commits into from
Jul 30, 2021

Conversation

codeboten
Copy link
Contributor

Description: Follow up to #3730, removing IntGauge and IntSum.

Link to tracking Issue: Part of #3534

Will rebase once #3730 is merged.

@project-bot project-bot bot added this to In progress in Collector Jul 27, 2021
@codeboten codeboten mentioned this pull request Jul 28, 2021
Merged
@bogdandrutu
Copy link
Member

Please rebase :)

@codeboten codeboten marked this pull request as ready for review July 28, 2021 18:11
@codeboten codeboten requested a review from a team as a code owner July 28, 2021 18:11
@codeboten codeboten requested a review from Aneurysm9 July 28, 2021 18:11
@bogdandrutu
Copy link
Member

Contrib still fails, we should try to make sure contrib passes, since we merged all outstanding PRs. Most likely we missed some usages :)

@codeboten codeboten closed this Jul 29, 2021
Collector automation moved this from In progress to Done Jul 29, 2021
@codeboten codeboten reopened this Jul 29, 2021
Collector automation moved this from Done to In progress Jul 29, 2021
@codeboten
Copy link
Contributor Author

@bogdandrutu contrib passes now, unsure that the deb failure is related to the PR itself.

Collector automation moved this from In progress to Reviewer approved Jul 30, 2021
@tigrannajaryan tigrannajaryan merged commit 5929f4f into open-telemetry:main Jul 30, 2021
Collector automation moved this from Reviewer approved to Done Jul 30, 2021
emaderer pushed a commit to emaderer/opentelemetry-collector that referenced this pull request Jul 30, 2021
@emaderer
Remove IntGauge/IntSum (open-telemetry#3731)
597cf82 
Follow up to open-telemetry#3730, removing `IntGauge` and `IntSum`.

**Link to tracking Issue:** Part of open-telemetry#3534 

Will rebase once open-telemetry#3730 is merged.
@codeboten codeboten deleted the codeboten/rm-int-gauge-sum branch June 22, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Collector
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codeboten @bogdandrutu @tigrannajaryan