adding support for Bytes attribute type #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/0.9.0-bytes
branch
2 times, most recently
from
364dd66
to
1ed9cd4
Compare
Merged
|
LGTM. |
|
Needs a rebase |
codeboten
force-pushed
the
codeboten/0.9.0-bytes
branch
from
1ed9cd4
to
dc0c6c9
Compare
|
@bogdandrutu rebased, looks like some failure in contrib is caused by an update of the go SDK? |
bogdandrutu
reviewed
Aug 3, 2021
bogdandrutu
reviewed
Aug 4, 2021
bogdandrutu
approved these changes
Aug 4, 2021
codeboten
force-pushed
the
codeboten/0.9.0-bytes
branch
from
3586218
to
e94bb60
Compare
bogdandrutu
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding support for Bytes attribute type.
Link to tracking Issue: Part of #3535
This is built on top of #3740.