fixing policy names in README example #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-ribeiro
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
songy23 and
tigrannajaryan
as code owners
|
I signed it. |
|
I signed it |
|
dependent on #388 |
songy23
reviewed
Oct 9, 2019
There was a problem hiding this comment.
Thanks for the contribution, though I think the whole section Tail-based Example (https://github.com/open-telemetry/opentelemetry-collector/pull/386/files#diff-04c6e90faac2675aa89e2176d2eec7d8R320) needs to be removed or rewritten since it's now a processor.
|
@songy23 The content at the moment is misleading then. I'd suggest deleting it. I'm going to try to look into issue open-telemetry/opentelemetry-collector-contrib#30155 and in the process I might just be able to rewrite it. Thoughts? |
|
Nevermind. I've just noticed the /todo/ in the readme file. I'll just close this PR. |
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to issue open-telemetry/opentelemetry-collector-contrib#30155 .