Move MapProvider to config package
#4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
changed the title
service/parserprovider to configservice/parserprovider to config
mx-psi
force-pushed
the
mx-psi/rename-mapprovider
branch
from
afe3cc8
to
e7a1495
Compare
|
I would definitely move the interface, the implementations may live in other place |
@bogdandrutu What about moving the interface to |
mx-psi
force-pushed
the
mx-psi/rename-mapprovider
branch
from
e7a1495
to
ee28b18
Compare
mx-psi
changed the title
service/parserprovider to configMapProvider to config package
|
Second attempt, updated description with changes; @bogdandrutu PTAL |
Codecov Report
@@ Coverage Diff @@
## main #4178 +/- ##
==========================================
- Coverage 87.73% 87.64% -0.09%
==========================================
Files 174 174
Lines 10335 10291 -44
==========================================
- Hits 9067 9020 -47
- Misses 1016 1018 +2
- Partials 252 253 +1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Oct 11, 2021
mx-psi
force-pushed
the
mx-psi/rename-mapprovider
branch
from
ee28b18
to
f7ec3d8
Compare
bogdandrutu
reviewed
Oct 15, 2021
mx-psi
force-pushed
the
mx-psi/rename-mapprovider
branch
2 times, most recently
from
dcc969b
to
bd1c6ea
Compare
mx-psi
force-pushed
the
mx-psi/rename-mapprovider
branch
from
bd1c6ea
to
e0dd610
Compare
bogdandrutu
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
parserprovider.MapProviderinterface toconfig.MapProvider.parserprovider.Watchabletoconfig.WatchableMapProvider.Link to tracking Issue: Updates #4177