Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scraperhelper to follow the recommended append model for pdata #4202

Merged
merged 1 commit into from Oct 15, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner October 15, 2021 21:21
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #4202 (6662a4c) into main (028fc46) will decrease coverage by 0.07%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4202      +/-   ##
==========================================
- Coverage   87.72%   87.64%   -0.08%     
==========================================
  Files         174      174              
  Lines       10329    10291      -38     
==========================================
- Hits         9061     9020      -41     
- Misses       1016     1018       +2     
- Partials      252      253       +1     
Impacted Files Coverage Δ
receiver/scraperhelper/scraper.go 88.88% <76.92%> (-11.12%) ⬇️
receiver/scraperhelper/scrapercontroller.go 93.93% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028fc46...6662a4c. Read the comment docs.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit bd87fb6 into open-telemetry:main Oct 15, 2021
@bogdandrutu bogdandrutu deleted the extendscraper branch October 15, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants