Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proto to 0.11.0 #4209

Merged

Conversation

codeboten
Copy link
Contributor

Description:
Updates proto submodule and regenerates the protos

Link to tracking Issue: Fixes #4208

@codeboten codeboten requested a review from a team as a code owner October 18, 2021 15:37
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #4209 (4c7533f) into main (92eb2c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4209   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files         174      174           
  Lines       10291    10291           
=======================================
  Hits         9020     9020           
  Misses       1018     1018           
  Partials      253      253           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92eb2c5...4c7533f. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten would suggest to switch to download the zip archive instead of submodule in the future. easier to upgrade.

@bogdandrutu
Copy link
Member

Please fix the unittests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update proto submodule & generate new protos
2 participants