Remove deprecated no-op flags to setup Colletor's logging #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rmloggerflags
branch
from
63bf940
to
b0bc1d8
Compare
Codecov Report
@@ Coverage Diff @@
## main #4213 +/- ##
==========================================
+ Coverage 87.64% 87.71% +0.06%
==========================================
Files 174 174
Lines 10291 10270 -21
==========================================
- Hits 9020 9008 -12
+ Misses 1018 1012 -6
+ Partials 253 250 -3
Continue to review full report at Codecov.
|
mx-psi
approved these changes
Oct 19, 2021
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
codeboten
reviewed
Oct 19, 2021
codeboten
approved these changes
Oct 19, 2021
|
Note: now logging options are being declared in the config file as in #4009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com