Refactor configauth, getters use the map instead of iteration #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
refactorconfigauth
branch
from
0ec18d7
to
90f5c8a
Compare
Codecov Report
@@ Coverage Diff @@
## main #4234 +/- ##
==========================================
- Coverage 87.93% 87.92% -0.02%
==========================================
Files 174 173 -1
Lines 10265 10263 -2
==========================================
- Hits 9027 9024 -3
- Misses 992 993 +1
Partials 246 246
Continue to review full report at Codecov.
|
codeboten
approved these changes
Oct 20, 2021
| for id, ext := range extensions { | ||
| // GetServerAuthenticator attempts to select the appropriate ServerAuthenticator from the list of extensions, | ||
| // based on the requested extension name. If an authenticator is not found, an error is returned. | ||
| func (a Authentication) GetServerAuthenticator(extensions map[config.ComponentID]component.Extension) (ServerAuthenticator, error) { |
There was a problem hiding this comment.
Will this eventually be split into a GetHTTPServerAuthenticator and a GetGRPCServerAuthentiator?
There was a problem hiding this comment.
I think so, I had exactly the same question in my mind while doing the refactoring. @jpkrohling for you to see this comment.
There was a problem hiding this comment.
I just created a new issue, to keep track of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com