Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify unmarshal logic by adding more supported hooks #4237

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Simplify unmarshal logic by adding more supported hooks #4237

merged 3 commits into from
Oct 22, 2021

Commits on Oct 20, 2021

  1. Simplify unmarshal logic by adding more supported hooks 

    * Add hook that supports "String -> encoding.TextUnmarshaler", e.g. zapcore.Level no longer need special unmarshaling
* Add hook that supports "String -> ComponentID"
* Add a special hook for map[string]interface{} -> map[ComponentID]interface{} to determine duplicates after space trimming, not sure if this error needs this special treatment.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1d55976 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Fix review comments 

    Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    905e4bb View commit details
    Browse the repository at this point in the history

  2. Improve error messages for unmarshaling errors of the ComponentID 

    Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
    @bogdandrutu
    bogdandrutu committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    92e2c29 View commit details
    Browse the repository at this point in the history