Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use directly the ComponentID in configauth #4238

Merged
merged 1 commit into from Oct 22, 2021

Conversation

bogdandrutu
Copy link
Member

Depends on #4237

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner October 21, 2021 00:00
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #4238 (dbdde3f) into main (bd13c61) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4238      +/-   ##
==========================================
+ Coverage   88.05%   88.07%   +0.01%     
==========================================
  Files         173      173              
  Lines       10200    10188      -12     
==========================================
- Hits         8982     8973       -9     
+ Misses        977      975       -2     
+ Partials      241      240       -1     
Impacted Files Coverage Δ
config/configauth/configauth.go 85.71% <100.00%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd13c61...dbdde3f. Read the comment docs.

Depends on open-telemetry#4237

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bogdandrutu bogdandrutu merged commit 108a49e into open-telemetry:main Oct 22, 2021
@bogdandrutu bogdandrutu deleted the configauthid branch October 22, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants