Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cmd/pdatagen -> model/internal/cmd/pdatagen #4243

Merged
merged 3 commits into from Oct 22, 2021

Conversation

codeboten
Copy link
Contributor

Description:
moving cmd/pdatagen code to model/internal

Link to tracking Issue: Fixes #4241

This is just the move of the package over, I can move model/internal/pdatagen/internal next, but wanted to minimize the changes in this PR.

@codeboten codeboten requested a review from a team as a code owner October 21, 2021 23:24
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #4243 (cb33572) into main (b927925) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4243      +/-   ##
==========================================
+ Coverage   87.92%   88.07%   +0.14%     
==========================================
  Files         173      173              
  Lines       10263    10188      -75     
==========================================
- Hits         9024     8973      -51     
+ Misses        993      975      -18     
+ Partials      246      240       -6     
Impacted Files Coverage Δ
model/pdata/generated_common.go 100.00% <ø> (ø)
model/pdata/generated_log.go 96.53% <ø> (ø)
model/pdata/generated_metrics.go 96.63% <ø> (ø)
model/pdata/generated_resource.go 100.00% <ø> (ø)
model/pdata/generated_trace.go 96.76% <ø> (ø)
config/identifiable.go 100.00% <0.00%> (ø)
config/configauth/configauth.go 85.71% <0.00%> (+3.89%) ⬆️
config/configunmarshaler/defaultunmarshaler.go 100.00% <0.00%> (+4.45%) ⬆️
config/configmap.go 81.98% <0.00%> (+10.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b927925...cb33572. Read the comment docs.

Makefile Outdated
@@ -360,7 +360,7 @@ genproto_sub:
# Generate structs, functions and tests for pdata package. Must be used after any changes
# to proto and after running `make genproto`
genpdata:
go run cmd/pdatagen/main.go
go run model/internal/pdatagen/main.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep model/internal/cmd

@codeboten codeboten changed the title move cmd/pdatagen -> model/internal/pdatagen move cmd/pdatagen -> model/internal/cmd/pdatagen Oct 22, 2021
@bogdandrutu bogdandrutu merged commit c3aa782 into open-telemetry:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move pdatagen as internal package to "model", do not export this module.
3 participants