configgrpc: Update ToDialOptions with settings
#4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ability to pass TelemetrySettings to ToDialOptions to configure underlying instrumentation library. Fixes open-telemetry#4424
Codecov Report
@@ Coverage Diff @@
## main #4451 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 178 178
Lines 10357 10357
=======================================
Hits 9394 9394
Misses 745 745
Partials 218 218
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Nov 18, 2021
Comment on lines
+251
to
+252
| opts = append(opts, grpc.WithUnaryInterceptor(otelgrpc.UnaryClientInterceptor(otelgrpc.WithTracerProvider(settings.TracerProvider)))) | ||
| opts = append(opts, grpc.WithStreamInterceptor(otelgrpc.StreamClientInterceptor(otelgrpc.WithTracerProvider(settings.TracerProvider)))) |
There was a problem hiding this comment.
The option is not supported yet open-telemetry/opentelemetry-go-contrib#1094
bogdandrutu
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to pass TelemetrySettings to ToDialOptions to configure underlying instrumentation library.
Fixes #4424