Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated consumererror.Combine #4597

Merged
merged 1 commit into from Dec 21, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner December 21, 2021 17:58
@project-bot project-bot bot added this to In progress in Collector Dec 21, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #4597 (01f9d98) into main (84b3706) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4597      +/-   ##
==========================================
+ Coverage   90.71%   90.77%   +0.05%     
==========================================
  Files         179      178       -1     
  Lines       10592    10561      -31     
==========================================
- Hits         9609     9587      -22     
+ Misses        765      757       -8     
+ Partials      218      217       -1     
Impacted Files Coverage Δ
service/command.go 100.00% <0.00%> (ø)
config/configmapprovider/default.go
service/internal/configprovider/default.go 100.00% <0.00%> (ø)
service/config_provider.go 88.23% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b3706...01f9d98. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Dec 21, 2021
@bogdandrutu bogdandrutu merged commit d623354 into open-telemetry:main Dec 21, 2021
Collector automation moved this from Reviewer approved to Done Dec 21, 2021
@bogdandrutu bogdandrutu deleted the rmdepcombine branch December 21, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants