Add an option to allow config.Map conversion in the service.ConfigProvider #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4634 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 181 181
Lines 10595 10598 +3
=======================================
+ Hits 9574 9577 +3
Misses 797 797
Partials 224 224
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
cfgmapconverte
branch
from
3fcd7f1
to
efe430c
Compare
dmitryax
reviewed
Jan 5, 2022
bogdandrutu
force-pushed
the
cfgmapconverte
branch
2 times, most recently
from
900278a
to
3ad8d99
Compare
dmitryax
approved these changes
Jan 5, 2022
…4595) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
cfgmapconverte
branch
from
3ad8d99
to
c5cbab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow backwards compatible "converters" to be implemented and still benefit of the default ConfigProvider implementation, as well as helping previous implementations which had a custom "config.MapProvider" to still use that + the new service.NewDefaultConfigProvider.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com