Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builder]: Enable unmarshal exact to help finding hard to find typos #4644

Merged
merged 1 commit into from Jan 6, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner January 5, 2022 23:23
@bogdandrutu bogdandrutu requested a review from owais January 5, 2022 23:23
@project-bot project-bot bot added this to In progress in Collector Jan 5, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #4644 (c13af73) into main (d552222) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4644      +/-   ##
==========================================
- Coverage   90.46%   90.45%   -0.02%     
==========================================
  Files         181      181              
  Lines       10611    10598      -13     
==========================================
- Hits         9599     9586      -13     
  Misses        788      788              
  Partials      224      224              
Impacted Files Coverage Δ
service/internal/configprovider/expand.go 70.00% <0.00%> (-8.19%) ⬇️
service/servicetest/configprovider.go 64.70% <0.00%> (ø)
service/config_provider.go 89.28% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d552222...c13af73. Read the comment docs.

@@ -1,7 +1,6 @@
dist:
module: go.opentelemetry.io/collector/cmd/otelcorecol
name: otelcorecol
include_core: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed.

Collector automation moved this from In progress to Reviewer approved Jan 6, 2022
@bogdandrutu bogdandrutu merged commit f5fb458 into open-telemetry:main Jan 6, 2022
Collector automation moved this from Reviewer approved to Done Jan 6, 2022
@bogdandrutu bogdandrutu deleted the enableunmarshalexact branch October 28, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants