fix: move compression.go into confighttp.go #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4651 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 179 180 +1
Lines 10652 10652
=======================================
Hits 9666 9666
Misses 765 765
Partials 221 221
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Jan 7, 2022
There was a problem hiding this comment.
Not sure if it is ok to make configgrpc depend on confighttp. Can we maybe consider a configcompression? Idea being other protocols (e.g. plain UDP) can use these constants as well.
Another option is confignet? Personally I prefer configcompression, any thoughts @tigrannajaryan @open-telemetry/collector-approvers ?
bogdandrutu
reviewed
Jan 8, 2022
hyunuk
force-pushed
the
move_CompressionType
branch
from
3bd0f2c
to
c2317d8
Compare
jpkrohling
reviewed
Jan 10, 2022
dmitryax
reviewed
Jan 10, 2022
codeboten
approved these changes
Jan 10, 2022
bogdandrutu
approved these changes
Jan 13, 2022
bogdandrutu
approved these changes
Jan 13, 2022
|
please fix lint |
bogdandrutu
reviewed
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moved every code in
internal/middleware/compression.gotoconfig/confighttp.goand tests as well.It also changed functions unexported except
CompressionType.Note: Functions in
compression.gowas iniatially created forotlphttpexporter, but it was changed to theconfighttpin this PR(see #4441 and the code).Link to tracking Issue:
#4627