Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the StartFunc/ShutdownFunc to component directly #4803

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add the StartFunc/ShutdownFunc to component directly #4803

merged 1 commit into from
Feb 18, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 3, 2022 •
edited

Updates #4681

@bogdandrutu bogdandrutu requested a review from a team as a code owner February 3, 2022 21:02
@project-bot project-bot bot added this to In progress in Collector Feb 3, 2022
@bogdandrutu bogdandrutu force-pushed the deprecatefunc branch 2 times, most recently from c4b9764 to 9252f70 Compare February 3, 2022 21:03
@bogdandrutu bogdandrutu changed the title Add the StartFunc/ShutdownFunc to component directly. Add the StartFunc/ShutdownFunc to component directly Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited

Codecov Report

Merging #4803 (9844b3c) into main (d5656d6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4803   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files         180      181    +1     
  Lines       10627    10627           
=======================================
  Hits         9633     9633           
  Misses        776      776           
  Partials      218      218
Impacted Files Coverage Δ
processor/processorhelper/logs.go 89.65% <ø> (ø)
processor/processorhelper/metrics.go 89.65% <ø> (ø)
processor/processorhelper/traces.go 89.65% <ø> (ø)
component/component.go 100.00% <100.00%> (ø)
component/componenthelper/component.go 100.00% <100.00%> (ø)
config/configauth/default_serverauthenticator.go 100.00% <100.00%> (ø)
exporter/exporterhelper/common.go 94.25% <100.00%> (ø)
processor/processorhelper/processor.go 100.00% <100.00%> (ø)
receiver/scraperhelper/scraper.go 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5656d6...9844b3c. Read the comment docs.

@bogdandrutu
Copy link
Member Author

@open-telemetry/collector-approvers ping

1 similar comment
@bogdandrutu
Copy link
Member Author

bogdandrutu commented Feb 14, 2022 •
edited

@open-telemetry/collector-approvers ping

@jpkrohling jpkrohling self-requested a review February 15, 2022 13:53
Collector automation moved this from In progress to Reviewer approved Feb 15, 2022
@jpkrohling
Copy link
Member

This needs a changelog entry, marking the deprecation and pointing people to the new API.

@bogdandrutu
Add the StartFunc/ShutdownFunc to component directly
9844b3c 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit c4134ba into open-telemetry:main Feb 18, 2022
@bogdandrutu bogdandrutu deleted the deprecatefunc branch February 18, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdandrutu @jpkrohling