Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move everything from exporterhelper to component. #4899

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

bogdandrutu
Copy link
Member

Updates #4681

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #4899 (c7b8de3) into main (004dd4d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c7b8de3 differs from pull request most recent head cf4fe13. Consider uploading reports for the commit cf4fe13 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4899      +/-   ##
==========================================
- Coverage   90.69%   90.69%   -0.01%     
==========================================
  Files         181      181              
  Lines       10618    10617       -1     
==========================================
- Hits         9630     9629       -1     
  Misses        772      772              
  Partials      216      216              
Impacted Files Coverage Δ
component/componenttest/nop_exporter.go 100.00% <100.00%> (ø)
component/exporter.go 100.00% <100.00%> (ø)
exporter/loggingexporter/factory.go 77.35% <100.00%> (ø)
exporter/otlpexporter/factory.go 91.54% <100.00%> (ø)
exporter/otlphttpexporter/factory.go 87.62% <100.00%> (ø)
internal/testcomponents/example_exporter.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004dd4d...cf4fe13. Read the comment docs.

component/componenttest/nop_exporter.go Show resolved Hide resolved
exporter/exporterhelper/factory.go Outdated Show resolved Hide resolved
component/exporter.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the exporterhelper branch 4 times, most recently from 82beed8 to 8f30631 Compare February 22, 2022 18:41
Collector automation moved this from In progress to Reviewer approved Feb 22, 2022
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 83c6ed1 into open-telemetry:main Feb 22, 2022
@bogdandrutu bogdandrutu deleted the exporterhelper branch February 22, 2022 23:30
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this pull request Feb 23, 2022
Updates open-telemetry#4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit that referenced this pull request Feb 23, 2022
Updates #4681

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Reviewer approved
Development

Successfully merging this pull request may close these issues.

None yet

4 participants