Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LogRecord.Name(), it was deprecated in the data model #5054

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team as a code owner March 21, 2022 12:37
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu changed the title Deprecate LogRecord.Name(), it was deprecated in the data model. Deprecate LogRecord.Name(), it was deprecated in the data model Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #5054 (861d21b) into main (1d2b265) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5054      +/-   ##
==========================================
- Coverage   91.08%   91.04%   -0.04%     
==========================================
  Files         180      180              
  Lines       10700    10700              
==========================================
- Hits         9746     9742       -4     
- Misses        737      740       +3     
- Partials      217      218       +1     
Impacted Files Coverage Δ
model/internal/pdata/generated_log.go 96.65% <ø> (ø)
model/internal/pdata/common.go 94.68% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2b265...861d21b. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 510dbab into open-telemetry:main Mar 21, 2022
@bogdandrutu bogdandrutu deleted the deprecatename branch March 21, 2022 16:49
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants