Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pdata] Rename ValueTypeArray to ValueTypeSlice #5066

Merged
merged 3 commits into from
Mar 23, 2022
Merged

[pdata] Rename ValueTypeArray to ValueTypeSlice #5066

merged 3 commits into from
Mar 23, 2022

Conversation

dmitryax
Copy link
Member

pdata.ValueTypeArray is removed without deprecation because it was introduced few commits before and not released yet.

Closes: #5065

@dmitryax
[pdata] Rename ValueTypeArray to ValueTypeSlice
ea9cb05 
`pdata.ValueTypeArray` is not deprecated because it was introduced few commits before and not released yet.
@dmitryax dmitryax requested a review from a team as a code owner March 23, 2022 06:52
@dmitryax dmitryax requested a review from Aneurysm9 March 23, 2022 06:52
@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited

Codecov Report

Merging #5066 (15fb8f4) into main (89da10b) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #5066   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files         180      180           
  Lines       10814    10814           
=======================================
  Hits         9846     9846           
  Misses        749      749           
  Partials      219      219
Impacted Files Coverage Δ
model/internal/pdata/common.go 94.26% <77.77%> (ø)
internal/otlptext/databuffer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89da10b...15fb8f4. Read the comment docs.

bogdandrutu
bogdandrutu approved these changes Mar 23, 2022
View reviewed changes
model/internal/pdata/common_test.go
func TestAttributeValueArray(t *testing.T) {
a1 := NewValueArray()
assert.EqualValues(t, ValueTypeArray, a1.Type())
func TestAttributeValueSlice(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate PR consider to remove Attribute from test names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll do

@bogdandrutu
Copy link
Member

Please rebase

@dmitryax
Copy link
Member Author

done

@dmitryax
Copy link
Member Author

dmitryax commented Mar 23, 2022 •
edited

contrib-tests / contrib_tests is failing because of removed ValueTypeArray which is expected. ValueTypeArray isn't part of to the latest release, it was added after 0.47.0, so I believe it can be removed right away. Let me know if there are any objections.

cc @bogdandrutu @Aneurysm9

@Aneurysm9
Copy link
Member

ValueTypeArray isn't part of to the latest release, it was added after 0.47.0, so I believe it can be removed right away.

I think that's correct. We don't have any releases with that identifier so there is no need to perpetuate it for compatibility.

@bogdandrutu bogdandrutu merged commit 1b76187 into open-telemetry:main Mar 23, 2022
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Mar 23, 2022
update otel core
0019dfa 
Follow up to open-telemetry/opentelemetry-collector#5066:
  Rename `Array` type of `pdata.Value` to `Slice`
  - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice`
  - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice`
@codeboten codeboten mentioned this pull request Mar 23, 2022
Merged
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Mar 24, 2022
update otel core (#8821)
15cae21 
* update otel core

Follow up to open-telemetry/opentelemetry-collector#5066:
  Rename `Array` type of `pdata.Value` to `Slice`
  - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice`
  - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice`

* fix lint
@dmitryax dmitryax deleted the rename-array branch March 24, 2022 17:34
foxlegend pushed a commit to foxlegend/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2022
update otel core (open-telemetry#8821)
d623d43 
* update otel core

Follow up to open-telemetry/opentelemetry-collector#5066:
  Rename `Array` type of `pdata.Value` to `Slice`
  - Deprecate `pdata.AttributeValueTypeArray` type in favor of `pdata.ValueTypeSlice`
  - Deprecate `pdata.NewAttributeValueArray` func in favor of `pdata.NewValueSlice`

* fix lint
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
@dmitryax @Nicholaswang
[pdata] Rename ValueTypeArray to ValueTypeSlice (open-telemetry#5066)
ef495ba 
* [pdata] Rename ValueTypeArray to ValueTypeSlice

`pdata.ValueTypeArray` is not deprecated because it was introduced few commits before and not released yet.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pdata] Rename ValueTypeArray to ValueTypeSlice for consistency with pdata.Slice
3 participants
@dmitryax @bogdandrutu @Aneurysm9