Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTLP to 0.16.0 #5202

Conversation

tigrannajaryan
Copy link
Member

Removed LogRecord.Name field (was deprecated earlier)

@tigrannajaryan
Copy link
Member Author

Opening as a draft see if there is anything else remaining in contrib that uses the field.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #5202 (344ab14) into main (2acc422) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5202      +/-   ##
==========================================
- Coverage   90.57%   90.56%   -0.01%     
==========================================
  Files         189      189              
  Lines       11116    11111       -5     
==========================================
- Hits        10068    10063       -5     
  Misses        826      826              
  Partials      222      222              
Impacted Files Coverage Δ
pdata/internal/generated_plog.go 96.65% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acc422...344ab14. Read the comment docs.

@tigrannajaryan
Copy link
Member Author

Used in azuremonitorexporter, need to fix this first: open-telemetry/opentelemetry-collector-contrib#9258

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 28, 2022
Removed LogRecord.Name field (was deprecated earlier)
Removed LogRecord.Name field (was deprecated earlier).
@tigrannajaryan tigrannajaryan marked this pull request as ready for review April 29, 2022 12:59
@tigrannajaryan tigrannajaryan requested a review from a team as a code owner April 29, 2022 12:59
@tigrannajaryan
Copy link
Member Author

@open-telemetry/collector-approvers we no longer have any references to the deleted LogRecord.Name in the codebase. Any concerns with merging this?

@bogdandrutu bogdandrutu merged commit 4b811dc into open-telemetry:main Apr 29, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/update-proto-0160 branch April 29, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants