[pdata] Rename methods dealing with slices of primitive type items #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
rename-primitive-slice-methods
branch
from
099c43f
to
0577bef
Compare
bogdandrutu
approved these changes
May 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #5344 +/- ##
==========================================
- Coverage 90.77% 90.52% -0.26%
==========================================
Files 190 190
Lines 11405 11435 +30
==========================================
- Hits 10353 10351 -2
- Misses 831 862 +31
- Partials 221 222 +1
Continue to review full report at Codecov.
|
- In preparation of migration to immutable slices for primitive type items the following methods are renamed:
- `Value.BytesVal` func is deprecated in favor of `Value.MBytesVal`.
- `Value.SetBytesVal` func is deprecated in favor of `Value.SetMBytesVal`.
- `Value.UpdateBytes` func is deprecated in favor of `Value.UpdateMBytes`.
- `Value.InsertBytes` func is deprecated in favor of `Value.InsertMBytes`.
- `Value.UpsertBytes` func is deprecated in favor of `Value.UpsertMBytes`.
- `<HistogramDataPoint|Buckets>.BucketCounts` funcs are deprecated in favor of
`<HistogramDataPoint|Buckets>.MBucketCounts`.
- `<HistogramDataPoint|Buckets>.SetBucketCounts` funcs are deprecated in favor of
`<HistogramDataPoint|Buckets>.SetMBucketCounts`.
- `HistogramDataPoint.ExplicitBounds` func is deprecated in favor of `HistogramDataPoint.MExplicitBounds`.
- `HistogramDataPoint.SetExplicitBounds` func is deprecated in favor of `HistogramDataPoint.SetMExplicitBounds`.
dmitryax
force-pushed
the
rename-primitive-slice-methods
branch
from
0577bef
to
cecf347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value.BytesValfunc is deprecated in favor ofValue.MBytesVal.Value.SetBytesValfunc is deprecated in favor ofValue.SetMBytesVal.Value.UpdateBytesfunc is deprecated in favor ofValue.UpdateMBytes.Value.InsertBytesfunc is deprecated in favor ofValue.InsertMBytes.Value.UpsertBytesfunc is deprecated in favor ofValue.UpsertMBytes.<HistogramDataPoint|Buckets>.BucketCountsfuncs are deprecated in favor of<HistogramDataPoint|Buckets>.MBucketCounts.<HistogramDataPoint|Buckets>.SetBucketCountsfuncs are deprecated in favor of<HistogramDataPoint|Buckets>.SetMBucketCounts.HistogramDataPoint.ExplicitBoundsfunc is deprecated in favor ofHistogramDataPoint.MExplicitBounds.HistogramDataPoint.SetExplicitBoundsfunc is deprecated in favor ofHistogramDataPoint.SetMExplicitBounds.This is the first step towards solving #5263