[cmd/builder] Update builder flags precedence #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5726 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 192 192
Lines 11411 11411
=======================================
Hits 10449 10449
Misses 768 768
Partials 194 194 Continue to review full report at Codecov.
|
|
There is a defect with this solution, closing until I sort it out. |
TylerHelmuth
commented
Jul 20, 2022
jpkrohling
reviewed
Jul 21, 2022
jpkrohling
approved these changes
Jul 21, 2022
bogdandrutu
reviewed
Jul 22, 2022
|
Please rebase to resolve conflicts. |
done |
jpkrohling
approved these changes
Jul 25, 2022
codeboten
approved these changes
Jul 26, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the builder's config initialization so that flags always take precedence over configuration files or default values.
I opted not to use the collector's resolvers/converter approach as it felt overkill for this command. This approach takes advantage of the command's existing use of global vars, which isn't the best, but is at least consistent.
Link to tracking Issue:
Fixes #5704
Testing:
Tested locally
Documentation:
I didn't update the README because it feels like flags taking precedence is the norm and the flags are already called out.