Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Make the in-memory and persistent queues more consistent #5764

Merged

Conversation

swiatekm-sumo
Copy link
Contributor

@swiatekm-sumo swiatekm-sumo commented Jul 31, 2022

Description:
This change is part of an effort to enable the persistent queue by default, without requiring the enable_unstable tag. Right now, there are minor inconsistencies between the queue behaviours, and this PR removes them. The intent is for enabling the persistent queue in the build by default to not change any behaviour.

More specifically:

  • queue names are now consistent, which required a change to a metric label for the persistent queue
  • the in-memory queue has the requeuing feature, though it's not enabled
  • added some missing tests for persistent queue configuration

This was originally part of #5711, which ended up doing too many things at once.

Link to tracking Issue: N/A

Testing:
Added some tests for parts of the persistent queue that weren't originally covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants