Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Deprecate Flags and SetFlags #5790

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Deprecates Flags and SetFlags in favor of FlagsStruct

Link to tracking Issue:
#5443

Testing:
Unit tests

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner August 2, 2022 21:21
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #5790 (b0416e4) into main (eb47b38) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5790      +/-   ##
==========================================
+ Coverage   91.49%   91.50%   +0.01%     
==========================================
  Files         192      192              
  Lines       11437    11433       -4     
==========================================
- Hits        10464    10462       -2     
+ Misses        778      777       -1     
+ Partials      195      194       -1     
Impacted Files Coverage Δ
pdata/internal/generated_pmetric.go 97.33% <ø> (-0.05%) ⬇️
pdata/internal/metrics.go 82.63% <100.00%> (+1.84%) ⬆️
processor/batchprocessor/batch_processor.go 89.63% <0.00%> (-1.04%) ⬇️
pdata/internal/common.go 95.38% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb47b38...b0416e4. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 27fdc2e into open-telemetry:main Aug 2, 2022
@TylerHelmuth TylerHelmuth deleted the deprecate-flags branch August 2, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants