-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[obsreport] Replace Prometheus namespace with metrics prefix #5939
Conversation
8c86f0b
to
288dece
Compare
"otelcol" part of the exposed metrics that is set as Prometheus namespace is replaced the same explicit metrics prefix. This change brings names consistency between metrics that can be reported with enabled or disabled "telemetry.useOtelForInternalMetrics" feature gate.
288dece
to
0bb640b
Compare
Codecov Report
@@ Coverage Diff @@
## main #5939 +/- ##
==========================================
- Coverage 91.93% 91.93% -0.01%
==========================================
Files 200 200
Lines 12406 12404 -2
==========================================
- Hits 11406 11404 -2
Misses 789 789
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise this looks good. Hurray for consistency :)
@@ -4,6 +4,9 @@ | |||
|
|||
### 🛑 Breaking changes 🛑 | |||
|
|||
- "otelcol" part of the exposed metrics that is set as Prometheus namespace is replaced the same explicit metrics prefix (#5939) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear to most users this will not be a breaking change as the prometheus metric exposed will be the same.
- "otelcol" part of the exposed metrics that is set as Prometheus namespace is replaced the same explicit metrics prefix (#5939) | |
- Update `otelcol_` part of the exposed Prometheus metrics to be set via a metric prefix instead of a namespace (#5939) |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This can also be accomplished by wrapping the edit: |
#6223 closes this |
"otelcol" part of the exposed metrics that is set as Prometheus namespace is replaced the same explicit metrics prefix. This change brings names consistency between metrics that can be reported with enabled or disabled "telemetry.useOtelForInternalMetrics" feature gate.
Resolves #5882