Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obsreport network metrics api, OTLP-gRPC receiver/exporter support #6712

Closed
wants to merge 4 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Dec 8, 2022

Description:

Adds a new obsreport API for counting network bytes sent and received by exporters and receivers. This functionality is opt-in on a component-by-component basis. These metrics are disabled in a Basic-level metrics configuration. Under Normal level, only the primary direction of travel is counted (sent for exporters, received for receivers). Under Detailed level, both directions of travel are counted.

Link to tracking Issue: #6638

Testing:
TODO: This is a WIP.

Documentation:
TODO: WIP

@jmacd
Copy link
Contributor Author

jmacd commented Dec 15, 2022

@bogdandrutu I left this PR in draft state because it has no tests, but I'd be willing to write tests if you approve of the approach. Please take a look.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 89.90% // Head: 89.15% // Decreases project coverage by -0.74% ⚠️

Coverage data is based on head (4024ee6) compared to base (3efa2bc).
Patch coverage: 23.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6712      +/-   ##
==========================================
- Coverage   89.90%   89.15%   -0.75%     
==========================================
  Files         248      249       +1     
  Lines       14342    14500     +158     
==========================================
+ Hits        12894    12928      +34     
- Misses       1187     1308     +121     
- Partials      261      264       +3     
Impacted Files Coverage Δ
obsreport/obsreport_sizer.go 0.00% <0.00%> (ø)
exporter/otlpexporter/otlp.go 74.01% <28.94%> (-19.40%) ⬇️
receiver/otlpreceiver/otlp.go 83.83% <90.00%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 3, 2023
@bogdandrutu bogdandrutu removed the Stale label Jan 4, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants