Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for concatenating multiple embedded uris, or uris with other string parts #7055

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Add support for concatenating multiple embedded uris, or uris with other string parts #7055

merged 1 commit into from
Jan 31, 2023

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jan 29, 2023 •
edited
Loading

Fixes #6932

@bogdandrutu bogdandrutu requested a review from a team as a code owner January 29, 2023 21:06
@codecov
Copy link

codecov bot commented Jan 29, 2023 •
edited
Loading

Codecov Report

Base: 89.33% // Head: 89.35% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c93d192) compared to base (a2f0153).
Patch coverage: 93.02% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7055      +/-   ##
==========================================
+ Coverage   89.33%   89.35%   +0.01%     
==========================================
  Files         239      239              
  Lines       13989    14014      +25     
==========================================
+ Hits        12497    12522      +25     
  Misses       1221     1221              
  Partials      271      271
Impacted Files Coverage Δ
confmap/resolver.go 96.73% <93.02%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mx-psi
mx-psi reviewed Jan 30, 2023
View reviewed changes
confmap/resolver.go Outdated Show resolved Hide resolved
confmap/resolver_test.go Outdated Show resolved Hide resolved
confmap/resolver_test.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the supportconcat branch 2 times, most recently from 65a7910 to 932980e Compare January 30, 2023 18:20
dmitryax
dmitryax reviewed Jan 30, 2023
View reviewed changes
confmap/resolver.go Outdated Show resolved Hide resolved
dmitryax
dmitryax approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with merging as is, but we will need to figure out how to enforce env var strings going forward. Maybe as a separate issue

dmitryax
dmitryax reviewed Jan 30, 2023
View reviewed changes
confmap/resolver_test.go Outdated Show resolved Hide resolved
@bogdandrutu
Add support for concatenating multiple embedded uris, or uris with ot…
c93d192 
…her string parts

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 202c030 into open-telemetry:main Jan 31, 2023
@bogdandrutu bogdandrutu deleted the supportconcat branch January 31, 2023 01:24
@crobert-1 crobert-1 mentioned this pull request Feb 27, 2023
Closed
@rmfitzpatrick rmfitzpatrick mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees

@mx-psi mx-psi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

confmap expand feature does not work in the middle of a string
3 participants
@bogdandrutu @mx-psi @dmitryax