Enable best effort serve by default of Prometheus Exporter #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamawhite
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
|
@liamawhite could you please also run |
pjanotti
approved these changes
Mar 27, 2020
|
@liamawhite could you please rebase? |
liamawhite
force-pushed
the
bump-prom-exporter
branch
from
289cb8b
to
8b31df7
Compare
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 162 162
Lines 11635 11635
=======================================
Hits 9090 9090
Misses 2132 2132
Partials 413 413 Continue to review full report at Codecov.
|
|
Please rebase again :( sorry |
Signed-off-by: Liam White <liam@tetrate.io>
liamawhite
force-pushed
the
bump-prom-exporter
branch
from
8b31df7
to
0dc5d58
Compare
|
Thanks @liamawhite - sorry for the multiple rebases |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update CODEOWNERS * Add Evan Torrie to CONTRIBUTING Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to latest github.com/orijtech/prometheus-go-metrics-exporter.
go get -u github.com/orijtech/prometheus-go-metrics-exporterSee orijtech/prometheus-go-metrics-exporter#6 for background.
Signed-off-by: Liam White liam@tetrate.io