Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null pointer exception in the logging exporter #743

Merged
merged 2 commits into from Mar 30, 2020
Merged

Fix null pointer exception in the logging exporter #743

merged 2 commits into from Mar 30, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu
Fix null pointer exception in the logging exporter
25d9300 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

Thanks @owais

@bogdandrutu bogdandrutu merged commit 9aa2386 into open-telemetry:master Mar 30, 2020
@bogdandrutu bogdandrutu deleted the fixlogging branch March 30, 2020 03:07
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
@jmacd
Disable parts of batch_span_processor test as flakes (open-telemetry#743
055e9c5 
)

* Name the BSP tests

* Add a drain wait group; use the stop wait group to avoid leaking a goroutine

* Lint & comments

* Fix

* Use defer/recover

* Restore the Add/Done...

* Restore the Add/Done...

* Consolidate select stmts

* Disable the test

* Lint

* Use better recover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@flands flands Awaiting requested review from flands

@pjanotti pjanotti Awaiting requested review from pjanotti

@rghetia rghetia Awaiting requested review from rghetia

@songy23 songy23 Awaiting requested review from songy23

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdandrutu @owais