New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for server interceptors #7510

Closed

jpkrohling wants to merge 1 commit into open-telemetry:main from jpkrohling:jpkrohling/issue7441

Member

jpkrohling commented Apr 6, 2023 •

edited

This PR adds support to interceptors, to be used on HTTP clients and servers.

We talked during the SIG meeting that I would implement server interceptors first, but given that the same interface would apply to clients, I think it was worth implementing both on this first PR.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

jpkrohling force-pushed the jpkrohling/issue7441 branch 2 times, most recently from df9b13b to f35ba74 Compare

April 6, 2023 13:54

codecov bot commented Apr 6, 2023 •

edited

Codecov Report

Patch coverage: 70.45% and project coverage change: -0.13 ⚠️

Comparison is base (5a55ff8) 91.10% compared to head (588a301) 90.98%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7510      +/-   ##
==========================================
- Coverage   91.10%   90.98%   -0.13%     
==========================================
  Files         295      297       +2     
  Lines       14373    14468      +95     
==========================================
+ Hits        13094    13163      +69     
- Misses       1011     1032      +21     
- Partials      268      273       +5

Impacted Files	Coverage Δ
config/configinterceptor/configinterceptor.go	`53.84% <53.84%> (ø)`
extension/interceptor/interceptor.go	`54.16% <54.16%> (ø)`
config/confighttp/confighttp.go	`87.14% <82.35%> (-1.54%)`	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.


          Initial support for server interceptors

588a301

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

jpkrohling force-pushed the jpkrohling/issue7441 branch from f35ba74 to 588a301 Compare

April 6, 2023 14:01

Contributor

github-actions bot commented Apr 21, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

Contributor

github-actions bot commented May 6, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions bot closed this

jpkrohling removed the Stale label

Member Author

jpkrohling commented May 10, 2023

jpkrohling reopened this

Contributor

github-actions bot commented May 25, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling removed the Stale label

Contributor

github-actions bot commented Jun 13, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling removed the Stale label

Contributor

github-actions bot commented Jul 11, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling removed the Stale label

Contributor

github-actions bot commented Jul 26, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling mentioned this pull request

[exporterhelper] New exporter helper for custom requests #7874

Closed

Contributor

github-actions bot commented Aug 9, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment