Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanprocessor #788

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Apr 5, 2020

Founded problems:

  • Maps don't handle nil entries in the underlying slice. What should we do?
  • Current data API do not allow to construct slices with nil entries for test - it should probably not allow doing this for normal conversions/pipeline.
  • Current protocol does not support undefined type for Attributes, should we support that, or we consider an empty entry as being type string with empty string value?

@bogdandrutu
Copy link
Member Author

@tigrannajaryan please take a look at the problems I found while converting Span processor.

@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #788 into master will increase coverage by 0.12%.
The diff coverage is 95.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
+ Coverage   85.56%   85.68%   +0.12%     
==========================================
  Files         154      156       +2     
  Lines       11520    11673     +153     
==========================================
+ Hits         9857    10002     +145     
- Misses       1292     1297       +5     
- Partials      371      374       +3     
Impacted Files Coverage Δ
processor/spanprocessor/span_processor.go 81.81% <86.95%> (ø)
internal/processor/filterspan/filterspan.go 98.29% <98.29%> (ø)
internal/data/common.go 95.14% <100.00%> (+0.30%) ⬆️
internal/processor/filterhelper/filter_helper.go 100.00% <100.00%> (ø)
processor/metrics.go 91.76% <100.00%> (+0.73%) ⬆️
processor/spanprocessor/factory.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 68.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b83bc...8e52e10. Read the comment docs.

}

// TestSpanProcessor_Values tests all possible value types.
func TestSpanProcessor_NilEmptyData(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add tests for:

  • one-span-one-nil.

@bogdandrutu bogdandrutu mentioned this pull request Apr 5, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like how minimal changes are needed.

@bogdandrutu bogdandrutu merged commit 990df3b into open-telemetry:master Apr 9, 2020
@bogdandrutu bogdandrutu deleted the spanprocessor branch April 9, 2020 16:35
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Ensure zipkin exporter reads and closes response body
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants