-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanprocessor #788
Spanprocessor #788
Conversation
@tigrannajaryan please take a look at the problems I found while converting Span processor. |
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
==========================================
+ Coverage 85.56% 85.68% +0.12%
==========================================
Files 154 156 +2
Lines 11520 11673 +153
==========================================
+ Hits 9857 10002 +145
- Misses 1292 1297 +5
- Partials 371 374 +3
Continue to review full report at Codecov.
|
21fd1cb
to
8e52e10
Compare
} | ||
|
||
// TestSpanProcessor_Values tests all possible value types. | ||
func TestSpanProcessor_NilEmptyData(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Add tests for:
- one-span-one-nil.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
8e52e10
to
4a35726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like how minimal changes are needed.
Ensure zipkin exporter reads and closes response body
Founded problems: