Update koanf to v2

[dbason]

This PR updates the koanf dependency to v2

[codeboten]

Is this addressing an issue or limitation with the older koanf library?

[mx-psi]

@knadh If you have the time, can you help us understand what changed between koanf v1 and v2 and what would be the benefits and changes if we update?

[knadh]

Hi @mx-psi. Functionally, no changes. The package structure has changed where every provider/parser has become its own module (with its own go.mod) to become a one repository-many modules system.

Benefits:
This removes references to all indirect dependencies in the main go.mod significantly de-cluttering it. These would never be compiled into the build, but go get .../koanf would still pull them in the dev environment in v1. Check out the main package's go.mod in v2.

It is safe (and also easy) to upgrade to v2 as it is functionally identical to v1. While this needn't be done on priority, I would recommend moving to v2 as that is where any continued improvements will land. v1 is frozen and will only receive security updates.

[mx-psi]

Thanks for the detailed explanation @knadh :) If it helps reduce our dependency footprint and it doesn't imply any user-facing changes I am all in for moving to v2. What do you think @codeboten ?

[codeboten]

Thanks for the explanation @knadh!

[codeboten]

Please run make gotidy to tidy up the dependencies

[dbason]

I suspect the tests failed due to the github outage.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (f990e99) 90.96% compared to head (a6d870a) 90.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7997   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         300      300           
  Lines       15090    15090           
=======================================
  Hits        13726    13726           
  Misses       1091     1091           
  Partials      273      273           

Impacted Files	Coverage Δ
cmd/builder/internal/command.go	62.50% <ø> (ø)
cmd/builder/internal/config/default.go	100.00% <ø> (ø)
confmap/confmap.go	90.12% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[codeboten]

Needs one more make crosslink && make gotidy... not sure why crosslink included a bunch of imports in a previous commit

[dbason]

I've done that now and squashed into the last commit

[codeboten]

Thanks it's looking good now