[OTLP/GRPC] Ensure OTLP receiver handles consume errors correctly #8080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
consume-errors-gre
branch
from
dc526f3
to
1a31b8b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8080 +/- ##
==========================================
+ Coverage 90.74% 90.76% +0.01%
==========================================
Files 341 341
Lines 18344 18389 +45
==========================================
+ Hits 16647 16691 +44
- Misses 1360 1361 +1
Partials 337 337 ☔ View full report in Codecov by Sentry. |
VihasMakwana
force-pushed
the
consume-errors-gre
branch
from
759c6c5
to
1a31b8b
Compare
|
@bogdandrutu can you have a quick look at this, if it's fine. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
evan-bradley
approved these changes
Aug 30, 2023
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
|
@bogdandrutu can you a quick look if it's fine by you? |
VihasMakwana
changed the title
|
Bogdan will be out for a few more weeks. @open-telemetry/collector-approvers could one of you please take a look? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
reviewed
Nov 15, 2023
atoulme
reviewed
Nov 15, 2023
atoulme
approved these changes
Nov 16, 2023
VihasMakwana
force-pushed
the
consume-errors-gre
branch
from
0b9635f
to
0226831
Compare
|
@bogdandrutu can we get this merged? #8676 seems to waiting on it. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
approved these changes
Jan 10, 2024
yurishkuro
approved these changes
Jan 11, 2024
mx-psi
approved these changes
Jan 11, 2024
TylerHelmuth
approved these changes
Jan 11, 2024
Comment on lines
+55
to
+62
| s, ok := status.FromError(err) | ||
| if !ok { | ||
| code := codes.Unavailable | ||
| if consumererror.IsPermanent(err) { | ||
| code = codes.InvalidArgument | ||
| } | ||
| s = status.New(code, err.Error()) | ||
| } |
There was a problem hiding this comment.
Since this error handling is the same for all signals I do wonder if it could be extracted and re-used, but that is an optimization we could handle later.
This was referenced Jan 23, 2024
codeboten
pushed a commit
that referenced
this pull request
Feb 1, 2024
The otlp receiver was recently updated via #8080 to properly propagate consumer errors back to clients as either permanent or retriable. The code we're using to indicate a non-retriable error is `codes.InvalidArgument`, which is the equivalent of `400` in HTTP. While 100% correct according to the [OTLP specification](https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#failures) to indicate a non-retriable error, I think `codes.Internal` (which is equivalent to HTTP `500`), better conveys the actual state of the collector in these situations. Related to #9357 (comment) --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
mx-psi
pushed a commit
that referenced
this pull request
Mar 27, 2024
…rrors (#9357) **Description:** Updates the receiver's http response to return a proper http status based on whether or not the pipeline returned a retryable error. Builds upon the work done in #8080 and #9307 **Link to tracking Issue:** Closes #9337 Closes #8132 Closes #9636 Closes #6725 **Testing:** Updated lots of unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Follow the receiver contract and return Unavailable for non-permanent and InvalidArgument for permanent errors for OTLP/gRPC receiver.
Leave the "Retry-After" field blank and let the client implement an exponential backoff strategy.
Link to tracking Issue: #4335
Testing: Added relevant test cases.