[otelcol] split into its own module #8443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
codeboten
force-pushed
the
codeboten/split-otelcol-module
branch
from
df79558
to
7293917
Compare
codeboten
force-pushed
the
codeboten/split-otelcol-module
branch
from
7293917
to
15ade7d
Compare
mx-psi
approved these changes
Sep 18, 2023
codeboten
force-pushed
the
codeboten/split-otelcol-module
branch
from
15ade7d
to
4bf2734
Compare
Fixes open-telemetry#7924 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/split-otelcol-module
branch
from
4bf2734
to
b5f89e7
Compare
codeboten
pushed a commit
that referenced
this pull request
Oct 20, 2023
Adds `go.opentelemetry.io/collector/otelcol` to `go.mod` template for the builder. This fixes #8692. Since #8443, the `otelcol` folder is its own component. Before this change, `otelcol_version` was enforced by the `collector` module dependency: https://github.com/open-telemetry/opentelemetry-collector/blob/287b98f6973fd6baa278150b9fca8c83abea0af4/cmd/builder/internal/builder/templates/go.mod.tmpl#L23 After this change, the `go mod tidy` step here: https://github.com/open-telemetry/opentelemetry-collector/blob/287b98f6973fd6baa278150b9fca8c83abea0af4/cmd/builder/internal/builder/main.go#L115 will add the latest available version for the `otelcol` module since none of the components actually depend on it. For example, with the `v0.86.0` builder config the output is as follows: ``` ❯ go mod tidy -v -compat=1.20 go: finding module for package go.opentelemetry.io/collector/otelcol go: found go.opentelemetry.io/collector/otelcol in go.opentelemetry.io/collector/otelcol v0.87.0 ``` Explicitly adding `otelcol` makes it so the `otelcol_version` is correctly honored. **Link to tracking Issue:** Fixes #8692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7924
Follows #8345